Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow percent signs in tag values and add CHANGES entry #1145

Merged
merged 3 commits into from
Jan 24, 2019
Merged

Allow percent signs in tag values and add CHANGES entry #1145

merged 3 commits into from
Jan 24, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Jan 24, 2019 •
edited
Loading

With this, the smb-alert:file_path tag can use placeholders.
Also, a CHANGES entry is added for the tag validator changes.

Checklist:

@timopollmeier
Allow percent signs in tag values
664a1b1 
With this, the smb-alert:file_path tag can use placeholders.
@timopollmeier timopollmeier added the work in progress This pull request should not be merged yet, more commits are expected label Jan 24, 2019
@timopollmeier timopollmeier self-assigned this Jan 24, 2019
@timopollmeier timopollmeier requested a review from a team January 24, 2019 15:00
@timopollmeier timopollmeier removed the work in progress This pull request should not be merged yet, more commits are expected label Jan 24, 2019
@bjoernricks bjoernricks merged commit 68dee37 into greenbone:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees

@timopollmeier timopollmeier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timopollmeier @bjoernricks